fix: apply effective rem to calc function using variables#345
Open
Jin-Byun wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix for a bug: Custom
effectiveRemvalue not being applied in Tailwind V4.calcfunction with rem-based variables (e.g--spacing: 0.25rem) for dynamic values (e.g.w-1 px-17 h-1.5) and more. (e.g..rounded-4xl { border-radius: calc(var(--radius-xl) * 4})Lengthvisitor in the compiler cannot updatecalcfunction with rem-based variable directly intopxvalue.Declarationvisitor using remToPx transformation similar toLengthvisitor catches and convert rem-based variables to px-based variables.Test Plan
effectiveRemset by:root { font-size: 16px; }is applied toborder-width: calc(var(--spacing) * 4)