Skip to content

Scope submodule URL rewrites to commands in Update Plugins workflow - #6

Draft
farfromrefug with Copilot wants to merge 2 commits into
masterfrom
copilot/fix-update-ui-mapbox-job-again
Draft

farfromrefug with Copilot wants to merge 2 commits into
masterfrom
copilot/fix-update-ui-mapbox-job-again

Conversation

Copilot AI commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Update Plugins was failing in update (ui-mapbox) after committing submodule bumps because git push resolved to https://github.com and lacked credentials. The failure came from persistent local url.*.insteadOf rewrites applied during submodule fetch.

  • Root cause

    • The workflow wrote SSH→HTTPS rewrites into repo-local git config before submodule operations.
    • Those rewrites persisted and affected later git push in update-submodules.sh.
  • Change

    • In .github/workflows/update.yml, replaced persistent git config --local --add url....insteadOf ... with command-scoped git -c url....insteadOf=... on:
      • git submodule sync --recursive
      • git submodule update --init --force --depth=1 --recursive
    • This keeps HTTPS rewriting limited to submodule fetch/sync only, without mutating local git config for subsequent push operations.
  • Representative diff pattern

git \
  -c url."https://github.com/".insteadOf=git@github.com: \
  -c url."https://github.com/".insteadOf=ssh://git@github.com/ \
  submodule update --init --force --depth=1 --recursive

Co-authored-by: farfromrefug <655344+farfromrefug@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job update (ui-mapbox) Scope submodule URL rewrites to commands in Update Plugins workflow Sep 16, 2026
Copilot AI requested a review from farfromrefug September 16, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants