Repository navigation
Feature: new model for keywords - #149
Merged
megannissel merged 10 commits intoSep 1, 2026
Merged
Conversation
davemfish
force-pushed
the
feature/119-controlled-keywords
branch
from
August 31, 2026 20:36
4f865e2 to
7a3b73f
Compare
davemfish
commented
Aug 31, 2026
|
|
||
| # Migrate metadata that pre-dates CoordinateReferenceSystem | ||
| if e['type'] == 'model_type' and e['loc'] == ('spatial', 'crs'): | ||
| if e['loc'] == ('spatial', 'crs') and e['type'] == 'model_type': |
Collaborator
Author
There was a problem hiding this comment.
I just re-ordered these for readability.
davemfish
commented
Sep 1, 2026
|
|
||
|
|
||
| class ResourceAttributeTests(unittest.TestCase): | ||
| """Tests for attributes shared by all resource types.""" |
Collaborator
Author
There was a problem hiding this comment.
Most of these tests were just moved to a different class for organizational purposes. The "keywords" tests were updated/added.
davemfish
marked this pull request as ready for review
September 1, 2026 13:03
megannissel
requested changes
Sep 1, 2026
megannissel
left a comment
megannissel
left a comment
Contributor
There was a problem hiding this comment.
Found two typos (aside from the BOUNDARIES one you already fixed!), but otherwise this looks great, Dave!
|
|
||
| #### CSV or other pandas-readable table | ||
| ```python | ||
| import geometamker |
Contributor
There was a problem hiding this comment.
Suggested change
| import geometamker | |
| import geometamaker |
| @@ -152,7 +184,7 @@ and/or `license` information. | |||
| A profile can be saved to a configuration file so that it will be re-used | |||
| everytime you use `geometamaker`. | |||
Contributor
There was a problem hiding this comment.
Not part of your current edits, but "everytime" should be two words
Suggested change
| everytime you use `geometamaker`. | |
| every time you use `geometamaker`. |
Collaborator
Author
Thank you, fixed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #119
The new
Keywordmodel follows loosely the attributes suggested here: https://github.com/ESIPFed/science-on-schema.org/blob/main/guides/Dataset.md#keywords-as-definedtermFor backwards-compatibility, the
keywordsattribute can still be assigned a sequence of strings. I updated it to asetto get the benefit of avoiding duplicates. And items can either be strings or the newKeywordtype.Also fixes #148