Repository navigation
Update CRS definitions; add geometamaker.load - #146
Merged
Merged
Conversation
…ributes in a TableResource. natcap#88
davemfish
changed the title
geometamaker.load
davemfish
marked this pull request as ready for review
July 23, 2026 13:59
phargogh
approved these changes
Jul 28, 2026
phargogh
left a comment
phargogh
left a comment
Member
There was a problem hiding this comment.
Thanks @davemfish ! I don't have any suggestions or comments on this PR. In addition to the CRS definitions, this is the first time I'm encountering migrations in geometamaker, so that's exciting to see!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors how projections are represented in order to handle cases where a projection does not have an EPSG code. In those cases, the Well-Known-Text representation is stored instead. While we could always opt for WKT, the brevity of the EPSG code seems desirable in the context of these documents. Authorities other than EPSG (e.g. ESRI) are uncommon and so rather than handling all possible authorities, I opted to fall back to WKT for those.
Existing metadata documents with the old data model will be automatically migrated to the new during
describe.I also added a
geometamaker.loadfunction as discussed in #111 .loaddoes not support migrating schema because it is safest to re-describe the original dataset to be sure that the CRS and other attributes are still accurate.Fixes #88
Fixes #111