Skip to content

CMR-10964: Change schemas to accommodate better collection quality information metadata#2448

Merged
eereiter merged 8 commits into
masterfrom
CMR_10964_umm_c
Jul 2, 2026
Merged

CMR-10964: Change schemas to accommodate better collection quality information metadata#2448
eereiter merged 8 commits into
masterfrom
CMR_10964_umm_c

Conversation

@eereiter

Copy link
Copy Markdown
Contributor

Overview

What is the objective?

New UMM-C version 1.18.6 to change the quality metadata field from a string to an object that contains more detailed information.

What are the changes?

Changed UMM-C, DIF 10, ECHO 10 schemas. Added translations to all of the supported schemas. Added migration up and down for UMM-C. created and updated tests.

What areas of the application does this impact?

UMM-C, DIF 10, ECHO 10, translations, UMM-C migrations. These fields are not searched so the changes do not include search or indexer code.

Required Checklist

  • New and existing unit and int tests pass locally and remotely
  • clj-kondo has been run locally and all errors in changed files are corrected
  • I have commented my code, particularly in hard-to-understand areas
  • I have made changes to the documentation (if necessary)
  • My changes generate no new warnings

Additional Checklist

  • I have removed unnecessary/dead code and imports in files I have changed
  • I have cleaned up integration tests by doing one or more of the following:
    • migrated any are2 tests to are3 in files I have changed
    • de-duped, consolidated, removed dead int tests
    • transformed applicable int tests into unit tests
    • reduced number of system state resets by updating fixtures. Ex) (use-fixtures :each (ingest/reset-fixture {})) to be :once instead of :each

Comment thread umm-spec-lib/resources/xml-schemas/dif10/dif_v10.2.xsd Outdated
Comment thread umm-spec-lib/resources/xml-schemas/dif10/UmmCommon_1.2.xsd Outdated
Comment thread umm-spec-lib/src/cmr/umm_spec/migration/version/collection.clj Outdated
Comment thread umm-spec-lib/src/cmr/umm_spec/models/umm_collection_models.clj
Comment thread umm-spec-lib/src/cmr/umm_spec/test/iso_shared.clj Outdated
Comment thread umm-spec-lib/src/cmr/umm_spec/umm_to_xml_mappings/echo10.clj Outdated
Comment thread umm-spec-lib/test/cmr/umm_spec/test/xml_to_umm_mappings/echo10.clj
Comment thread umm-spec-lib/test/cmr/umm_spec/test/xml_to_umm_mappings/dif10.clj
Comment thread umm-spec-lib/src/cmr/umm_spec/xml_to_umm_mappings/iso_smap.clj Outdated
Comment thread umm-spec-lib/src/cmr/umm_spec/xml_to_umm_mappings/echo10.clj Outdated

@mmorahan mmorahan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make some of the changes from the previous reviewer.

Comment thread umm-spec-lib/src/cmr/umm_spec/test/iso_shared.clj Outdated
@eudoroolivares2016 eudoroolivares2016 changed the title CMR-10964 Change schemas to accommodate better collection quality information metadata CMR-10964: Change schemas to accommodate better collection quality information metadata Jun 23, 2026
@codecov-commenter

codecov-commenter commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.33333% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.25%. Comparing base (d304270) to head (e8534a0).
⚠️ Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
...-lib/src/cmr/umm_spec/models/umm_common_models.clj 50.00% 0 Missing and 2 partials ⚠️
...lib/src/cmr/umm_spec/xml_to_umm_mappings/dif10.clj 91.66% 0 Missing and 2 partials ⚠️
...ib/src/cmr/umm_spec/xml_to_umm_mappings/echo10.clj 95.45% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2448      +/-   ##
==========================================
+ Coverage   58.20%   58.25%   +0.05%     
==========================================
  Files        1069     1071       +2     
  Lines       74278    74391     +113     
  Branches     2165     2169       +4     
==========================================
+ Hits        43233    43338     +105     
+ Misses      29028    29027       -1     
- Partials     2017     2026       +9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jceaser jceaser left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a formatting change, everything else I think is just questions.

Comment thread umm-lib/resources/schema/dif10/dif_v10.2.xsd Outdated
Comment thread umm-lib/resources/schema/echo10/Collection.xsd
Comment thread umm-spec-lib/resources/xml-schemas/dif10/dif_v10.2.xsd
@eereiter eereiter merged commit 0333fb7 into master Jul 2, 2026
2 of 4 checks passed
@eereiter eereiter deleted the CMR_10964_umm_c branch July 2, 2026 15:21
jaortega527 added a commit that referenced this pull request Jul 6, 2026
…ality information metadata (#2448)"

This reverts commit 0333fb7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants