[Feature] Responsive Application View#623
Merged
Merged
Conversation
- Nest navigation to browser library destinations - Abstracted isNarrow calculation - Responsively set browser width
- Extracted save playlist dialog - NowPlayingPlaylist - NowPlayingItemView - Control `NowPlaying` width from calling component - Only navigate to `NowPlayingScreen` if screen `isNarrow` - Account for system bars when drawing Now Playing
- Open playlist drawer using `ResponsiveState` - Fixed constraints of landscape browser view - Adapt NowPlaying Views to `ResponsiveState` - Removed `playlistDrawerState`
davidvedvick
force-pushed
the
feature/responsive-application-view
branch
from
9b051a4 to
0bda453
Compare
7 tasks
Prevent unnecessary navigation with `NavController.peek()` and `NavController.isNotEmpty()` and extensions.
- Always use a bottom sheet scaffold - Fix remember keys of AnchoredDraggableState - Pull draggableState out of NowPlayingNarrowView
- Offset browser drawer if split is present - Set minimum now playing width
- Back button (ESC) returns to refresh button if focus is in list - Navigating to child item in list focuses on refresh button first
davidvedvick
force-pushed
the
feature/responsive-application-view
branch
from
0bda453 to
527e2de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.