Repository navigation
Run find-replace on the pre-new-admin admin - #5
Merged
Merged
Conversation
Ports the module from develop onto the legacy admin: - The admin controller lives in admin/controllers, extends the old Base, and offers the `search` and `replace` permission strings. - `moduleName` becomes `findReplace` so the router can build the controller namespace; the module folder follows it. - Permission strings and admin URLs live in src so the queue task, the API, and the views can use them without loading the controller. - The results screen brings its own progress bar and badge colours, which the Bootstrap 3 admin does not have. - Dependencies and CI target feature/pre-new-admin. The JSON status action is dropped; the API already serves it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the module from
developonto the legacy admin.feature/pre-new-adminwas cut from thedeveloptip, so this PR is only the adaptation.admin/controllers/FindReplace.php, extends the oldBase, and offerssearchandreplacepermissions. The legacy strings areadmin:findreplace:findreplace:searchandadmin:findreplace:findreplace:replace; develop's upgrade migration (Map pre-new-admin permission strings to permission classes #4) maps them to the permission classes.moduleNameisfindReplace. The old router builds the controller class asNails\Admin\{ucfirst(moduleName)}, which a hyphen breaks. The module folder (findReplace/) and email template paths follow it.Admin\PermissionandAdmin\Urllive insrc, so the queue task, API, and views can use them without loading the controller. Admin screens are atadmin/findReplace/findReplace.status()admin action is dropped; the API already serves search status.feature/pre-new-admin.Needs
Manager::isProcessed()from nails/module-queue#22.Testing
feature/pre-new-admindependencies, including newtests/Admin/PermissionTest.php(permission strings, router namespace, URLs).find-replace:fields -v, a search queued and completed by a realqueue:work, and the completion email linked toadmin/findReplace/findReplace/results.🤖 Generated with Claude Code