Skip to content

Resolve CMS pages, areas, blocks and menus in find-replace results (pre-new-admin) - #467

Merged
hellopablo merged 2 commits into
feature/pre-new-adminfrom
feature/pre-new-admin-find-replace-resolvers
Nov 2, 2026
Merged

hellopablo merged 2 commits into
feature/pre-new-adminfrom
feature/pre-new-admin-find-replace-resolvers

Conversation

@hellopablo

Copy link
Copy Markdown
Member

Summary

Ports #466 to feature/pre-new-admin, so find-replace results are resolved the same way on both branches. See that PR for what each resolver does.

  • Cherry-picks the develop commit (-x).
  • Edit links use the pre-new-admin paths (admin/cms/{pages,area,block,menu}/edit/{id}) instead of Controller::url(). Admin controllers on this branch are only loaded by the admin router.
  • Adds the common URL helper to PHPStan's scanFiles so siteUrl() is known.

Testing

  • composer test passes. PHPStan: no new errors against feature/pre-new-admin.
  • Checked in a pre-new-admin app with real data: the resolvers are listed by find-replace:fields, and find-replace:search returns titled hits whose links point at the admin routes above. Large tables resolve, because ID lookups are chunked.

Docs: nails/docs#36.

🤖 Generated with Claude Code

hellopablo and others added 2 commits November 2, 2026 10:19
Pages, areas, blocks, menus and menu items name the record behind each hit and
link to its edit screen. Menu items open their menu. Pages carry a status facet
and badge; deleted pages have no edit link.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 7fdc89e)
Admin controllers on this branch are only loaded by the admin router, so build
edit links from their admin paths instead of Controller::url().

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@hellopablo
hellopablo merged commit e03b504 into feature/pre-new-admin Nov 2, 2026
5 checks passed
@hellopablo
hellopablo deleted the feature/pre-new-admin-find-replace-resolvers branch November 2, 2026 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant