Repository navigation
Tighten CMS find-replace exclusions - #460
Merged
Merged
Conversation
- Remove cms_menu_item.url from readOnly() so menu URLs can be updated when moving a domain or path. - Add cms_page.draft_breadcrumbs and cms_page.published_breadcrumbs to readOnly(); both are generated from parent page titles, so a direct edit is overwritten or goes stale. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cms_menu_item.urlfromreadOnly(). Menu URLs are a typical target when moving a domain or path.cms_page.draft_breadcrumbsandcms_page.published_breadcrumbs. They are built from parent page titles (src/Model/Page.php,moveTo/slug-regeneration path), so a direct edit is overwritten on the next move or goes stale.cms_block.locatedinvestigationChecked what writes
located(src/Admin/Controller/Block.php,src/Model/Block.php,admin/views/Block/edit.php): it's a free-text field an admin types when creating a block, describing where it's used in templates (e.g. "Homepage > Header"). It's not auto-generated and not purely internal — it's editor-authored metadata, same character aslabel/description. Decision: left unchanged (fully searchable and replaceable), per the brief's "if it isn't editor-authored copy, make it read-only" — it is editor-authored, so no restriction was added.Test plan
tests/FindReplace/Exclusion/PackageTest.phpupdated and passing../vendor/bin/phpunit).🤖 Generated with Claude Code