Repository navigation
feat: serve admin avatars through the picture helper - #281
Merged
Merged
Conversation
The 2x candidate is a real 70px crop, so a cached 35px file is never requested with an @2x suffix.
Profile images get a 200px source on 2x displays. The avatar is an img so object-fit can cover the circle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nails\Cdn\Helper\Picture, with a 2x source at double the crop size (70px and 200px).@2xsuffix.Pictureonly accepts a CDN object.Depends on nails/module-cdn#472. Without that change, a density-only source is emitted with an empty
mediaattribute and the 2x crop loads on 1x displays too.Test plan
<picture>whose source is the 70px crop withmedia="(min-resolution: 2dppx)", and a user without a photo still shows the blank avatar.@2xappended.