Skip to content

Build and install grimblast from source#1680

Open
hurlbutt wants to merge 1 commit into
mylinuxforwork:mainfrom
hurlbutt:build-grimblast-from-source
Open

Build and install grimblast from source#1680
hurlbutt wants to merge 1 commit into
mylinuxforwork:mainfrom
hurlbutt:build-grimblast-from-source

Conversation

@hurlbutt

Copy link
Copy Markdown
Contributor

Description

After merging #1650, a user indicated that grimblast on their Fedora installation did not support the --filename parameter. Unlike Arch-based installations that use grimblast-git from the AUR, Fedora and OopenSUSE installations copy a cached (and older) version of the grimblast script into their local bin.

We could update the script in this repo, but it wouldn't solve the issue of Fedora and openSUSE users not receiving updates to the script over time (and requiring monitoring of the external repo to know when changes are made). Cloning and building locally would eliminate the need to update the cached version of the script.

Changes

  • Removes setup/scripts/grimblast
  • Adds script to remove locally installed instances of grimblast and installs grimblast from source
  • Updated post-fedora.sh and post-opensuse.sh to call new script instead of copying source file into /usr/bin

How Has This Been Tested?

I've tested the clean-install-grimblast.sh script on Arch Linux to confirm it working (after uninstalling grimblast-git from the AUR). I have not tested this as part of a Fedora or openSUSE installation due to lack of access to those environments. If anyone wants to test on those platforms, it would be appreciated.

  • Tested on Arch Linux/Based Distro.
  • Tested on Fedora Linux/Based Distro.
  • Tested on openSuse.
~/Projects/github/dotfiles/setup main 
❯ sudo cp scripts/grimblast /usr/bin

~/Projects/github/dotfiles/setup main 
❯ which grimblast
/usr/bin/grimblast

~/Projects/github/dotfiles/setup main 
❯ git branch
  build-grimblast-from-source
* main

~/Projects/github/dotfiles/setup main 
❯ git checkout build-grimblast-from-source
Switched to branch 'build-grimblast-from-source'
Your branch is up to date with 'origin/build-grimblast-from-source'.

~/Projects/github/dotfiles/setup build-grimblast-from-source 
❯ which grimblast
/usr/bin/grimblast

~/Projects/github/dotfiles/setup build-grimblast-from-source 
❯ ./clean-install-grimblast.sh 
removed '/usr/bin/grimblast'
Cloning into '/tmp/tmp.0DcUK1179k'...
remote: Enumerating objects: 67, done.
remote: Counting objects: 100% (67/67), done.
remote: Compressing objects: 100% (58/58), done.
remote: Total 67 (delta 10), reused 30 (delta 5), pack-reused 0 (from 0)
Receiving objects: 100% (67/67), 51.41 KiB | 1.12 MiB/s, done.
Resolving deltas: 100% (10/10), done.
make: Entering directory '/tmp/tmp.0DcUK1179k/grimblast'
scdoc < grimblast.1.scd > grimblast.1
make: Leaving directory '/tmp/tmp.0DcUK1179k/grimblast'
make: Entering directory '/tmp/tmp.0DcUK1179k/grimblast'
'grimblast.1' -> '/usr/local/share/man/man1/grimblast.1'
'grimblast' -> '/usr/local/bin/grimblast'
make: Leaving directory '/tmp/tmp.0DcUK1179k/grimblast'

~/Projects/github/dotfiles/setup build-grimblast-from-source 
❯ which grimblast
/usr/local/bin/grimblast

Checklist

Please ensure your pull request meets the following requirements:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • My changes do not introduce new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes.

Related Issues

Addresses issues in #1650

Additional Notes

If we want to pin grimblast to a specific commit versus always using main for stability reasons, we can update the script to checkout that specific commit before building/installing.

@hurlbutt

Copy link
Copy Markdown
Contributor Author

@mylinuxforwork - To confirm post-fedora.sh and post-opensuse.sh are called after any update to ML4W (whether from stable or rolling), correct? Also, I would appreciate your perspective whether you want Fedora and OpenSUSE users using the latest grimblast version or whether you want to pin a specific version.

@hurlbutt

Copy link
Copy Markdown
Contributor Author

@mylinuxforwork - I saw you released 2.14.0 today. We may need to consider a patch release for this PR if more Fedora and openSUSE users raise bug issues due to an older version of grimblast being installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant