Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests to Run

The following tests should be run to verify this PR:

Critical (directly affected)

  • webhook_server/tests/test_app.py::TestLifespan::test_lifespan_mcp_init β€” Tests MCP initialization in app lifespan, which imports and uses mcp.server.streamable_http_manager.StreamableHTTPSessionManager β€” the mcp v1->v2 major upgrade could change this class's API or location (High confidence)

Standard (regression safety)

  • webhook_server/tests/test_logging_separation.py::test_mcp_logging_configuration β€” Tests MCP logger configuration and handler setup; mcp v2 may change logger names or logging behavior referenced in the test (Medium confidence)
  • webhook_server/tests/test_logging_separation.py::test_mcp_logger_without_hook_id_is_noise β€” Tests filtering of mcp.server.streamable_http logger β€” logger name may change in mcp v2 (Medium confidence)
  • webhook_server/tests/test_logging_separation.py::test_mcp_server_log_without_hook_id_is_noise β€” Tests filtering of mcp_server.log infrastructure logger β€” mcp v2 may alter logging patterns (Medium confidence)
  • webhook_server/tests/test_logging_separation.py::test_infra_logger_with_hook_id_is_not_noise β€” Tests that MCP infrastructure loggers with hook_id are preserved β€” verifies MCP logger name constants still valid after v2 upgrade (Medium confidence)

Summary

  • 2 test files recommended (1 critical, 4 standard)
  • AI Provider: Claude (claude-opus-4-6[1m])

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests to Run

The following tests should be run to verify this PR:

Critical (directly affected)

  • webhook_server/tests/test_app.py::TestLifespan::test_lifespan_mcp_init β€” Tests MCP initialization in app lifespan, which imports from mcp.server.streamable_http_manager β€” the mcp v1β†’v2 major upgrade may change this module's API (High confidence)
  • webhook_server/tests/test_app.py β€” app.py imports mcp and fastapi_mcp; the full test suite for app.py should run to catch any breakage from the mcp v2 upgrade affecting app startup, routing, or error handling (High confidence)

Standard (regression safety)

  • webhook_server/tests/test_logging_separation.py β€” Tests MCP logging configuration and mcp.server.streamable_http logger filtering β€” mcp v2 may change logger names or logging behavior (Medium confidence)

Summary

  • 2 test files recommended (2 critical, 1 standard)
  • AI Provider: Claude (claude-opus-4-6[1m])

Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ dependencies = [
"pydantic>=2.8.0",
"psutil>=7.0.0",
"fastapi-mcp>=0.4.0",
"mcp>=1.9,<2",
"mcp>=2,<3",
"pi-sidecar-client>=4.2.0",
"aiohttp>=3.9.0",
]
Expand Down
85 changes: 74 additions & 11 deletions uv.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.