Skip to content

chore: clear what the json store removal left behind - #167

Merged
musingfox merged 6 commits into
mainfrom
muster/sqlite-leftovers
Nov 10, 2026
Merged

chore: clear what the json store removal left behind#167
musingfox merged 6 commits into
mainfrom
muster/sqlite-leftovers

Conversation

@musingfox

@musingfox musingfox commented Nov 10, 2026

Copy link
Copy Markdown
Owner

Summary

Leftovers from removing the json store (#163):

  • Delete publish_html_digest and Deps.publish, which no run reached; their retry tests now pin publish_site.
  • The settings page no longer sends readers to sources.yaml and cyris.toml, which no run reads.
  • The onboarding no-key line names the restart each install path needs (docker compose up -d --force-recreate under compose).
  • Drop the json branches the removal orphaned, and delete PagesClient.deploy, which only tests called.
  • The rss docs say the feed list lives in D1, even on a SQLite install.

Ticket: local-sqlite-backend (vault pm/cyris/tasks).

Verification

  • scripts/check.sh passed outside the sandbox, and an independent review passed.

🤖 Generated with Claude Code

musingfox and others added 6 commits November 9, 2026 23:20
@musingfox @claude
refactor: delete publish_html_digest and Deps.publish
3953ab6 
No run reaches them: bootstrap bound publish to None and the SQLite and D1 paths publish through publish_site. tests/test_publish.py now pins every deploy-retry assertion against publish_site, and the Discord publish-outcome test drives publish_site.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@musingfox @claude
fix(ui): stop pointing the settings page at files nobody reads
0c0b9c2 
The read-only notices sent a reader to sources.yaml and cyris.toml, which no run reads since the json store went. They now state the fact only; the probe matches.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@musingfox @claude
fix(onboarding): name the restart each install path needs
099fbf8 
Under compose a restart does not re-read env_file; it takes docker compose up -d --force-recreate. The no-key line now gives both paths, and a guard test pins it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@musingfox @claude
chore: drop the json branches the store removal orphaned
c5d6a9f 
The app Worker's json backend checks, the dead None branches in propose_rerun.py, and the rss Worker's stale ArticleStore wording and json-store paragraph.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@musingfox @claude
refactor: delete PagesClient.deploy, which only tests called
a2da466 
Its tests now call deploy_files over _collect(tmp_path) with every assertion kept. The empty-directory refusal moves to deploy_manifest's 'nothing to deploy', the live path's equivalent, since deploy_files takes a list and does not refuse an empty one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@musingfox @claude
docs(rss): say the feed list lives in D1, even on SQLite
326a11f 
The Worker reads Cloudflare D1 (feeds.js) and sources push writes D1 whatever the backend; 'the store' misled a SQLite reader.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 10, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@claude

claude Bot commented Nov 10, 2026

Copy link
Copy Markdown

Reviewed the diff (dead-code removal of publish / publish_html_digest / PagesClient.deploy, if d1 guards, and copy changes that drop the cyris.toml references). I found nothing worth raising.

  • build_deps always set publish=None, so the removed branch in run_digest was unreachable. published is still initialised before use.
  • build_d1_client never returns None, so dropping the if d1 guards in propose_rerun.py is safe.
  • A grep finds no remaining references to the removed symbols or the old strings in src, tests, scripts or docs.
  • The tests moved to publish_site and deploy_manifest, and they still cover the retry, verify and empty-manifest paths.

I didn't run the test suite.

@musingfox

musingfox commented Nov 10, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-10T14:13:31.988301Z 326a11f Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 10, 2026

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: 326a11fc4e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@musingfox
musingfox merged commit 47a8876 into main Nov 10, 2026
3 checks passed
@musingfox
musingfox deleted the muster/sqlite-leftovers branch November 10, 2026 17:06
musingfox added a commit that referenced this pull request Nov 10, 2026
@musingfox @claude
test(topics): drop Deps.publish from the filter topic tests
3907f84 
#167 deleted Deps.publish while #168 was open, and #168's new
tests/test_filter_topics.py still passed publish=None, so main's CI
and release both failed on ff6e6b2 with five TypeErrors. Each PR's
own CI was green; only their merge broke.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
musingfox added a commit that referenced this pull request Nov 10, 2026
@musingfox @claude
docs(architecture): log #165, #166 and #168 in §7
9ab8b89 
#167 changed nothing in §1–§6, so it has no row.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@musingfox