Skip to content

Open links in standard dialog texts - #233

Open
grliszas14 wants to merge 1 commit into
musescore:mainfrom
grliszas14:app_url_fix
Open

Open links in standard dialog texts#233
grliszas14 wants to merge 1 commit into
musescore:mainfrom
grliszas14:app_url_fix

Conversation

@grliszas14

Copy link
Copy Markdown
Contributor

Resolves: audacity/audacity#11725

  • I signed the CLA as username:
  • The title of the PR describes the problem it addresses.
  • Each commit's message describes its purpose and effects, and references the issue it resolves. If changes are extensive, there is a sequence of easily reviewable commits.
  • The code in the PR follows the coding rules.
  • I understand all aspects of the code I'm contributing and I'm able to explain it if requested.
  • The code compiles and runs on my machine, preferably after each commit individually. I have manually tested and verified that my changes fulfil their intended purpose.
  • No prior attempts to resolve this problem exist, or if they do, I listed them in my PR description and described how I avoided repeating past mistakes.
  • There are no unnecessary changes.
  • I created a unit test or vtest to verify the changes I made (if applicable).

@grliszas14
grliszas14 requested review from Eism and kryksyh August 19, 2026 11:32
@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: fbb6f800-e0c4-4230-ae0a-6464db4d277d

📥 Commits

Reviewing files that changed from the base of the PR and between 220f4b0 and 5e61f6f.

📒 Files selected for processing (1)
  • framework/uicomponents/qml/Muse/UiComponents/StyledTextLabel.qml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

StyledTextLabel now sets mouse.accepted according to whether the pointer hovers over a link. Link presses are accepted, while non-link presses remain rejected.

Merge Risk: ⚪ Minimal · up to 5e61f

This is a narrowly scoped change to how links are opened in standard dialog text, with no actionable merge-blocking risk remaining beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: enabling links in standard dialog text.
Description check ✅ Passed The description includes the resolved issue and completed checklist; the optional test checkbox is left unchecked.
Linked Issues check ✅ Passed The change enables link clicks in dialog text and addresses issue #11725.
Out of Scope Changes check ✅ Passed The one-line QML change is directly related to enabling links in standard dialog text.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Jojo-Schmitz

Jojo-Schmitz commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Would this be fixing the issue mentioned in musescore/MuseScore#33712 (comment) ?

@grliszas14

Copy link
Copy Markdown
Contributor Author

@Jojo-Schmitz it should, yes

@Jojo-Schmitz

Copy link
Copy Markdown
Contributor

Wonderful, looking forward to it getting merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The link in the check for updates dialog is broken

3 participants