Skip to content

[4.7.5] --score-media: fix various crashes - #34650

Merged
RomanPudashkin merged 3 commits into
musescore:4.7from
RomanPudashkin:fix_score_media_crash_47
Aug 20, 2026
Merged

[4.7.5] --score-media: fix various crashes#34650
RomanPudashkin merged 3 commits into
musescore:4.7from
RomanPudashkin:fix_score_media_crash_47

Conversation

@RomanPudashkin

Copy link
Copy Markdown
Contributor

No description provided.

@RomanPudashkin

Copy link
Copy Markdown
Contributor Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Full review finished.

@RomanPudashkin RomanPudashkin moved this to In Progress in MuseScore Studio 4.7.5 Aug 20, 2026
@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 2d4636d1-bcb6-4530-b398-f9427a0f5f90

📥 Commits

Reviewing files that changed from the base of the PR and between 215d544 and 3994151.

📒 Files selected for processing (6)
  • src/engraving/dom/instrument.cpp
  • src/engraving/rw/read400/tread.cpp
  • src/engraving/rw/read410/tread.cpp
  • src/engraving/rw/read460/tread.cpp
  • src/importexport/imagesexport/internal/svggenerator.cpp
  • src/importexport/musicxml/internal/export/exportmusicxml.cpp

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

Instrument templates and legacy readers now create a default channel when no channels exist. The channel uses the default name and recognized MIDI program. Existing channels still receive the recognized program when unset. MusicXML export now resolves invalid percussion lines from the instrument drumset, with line 0 as fallback. SVG metric diagnostics use debug logging, and chord-line diagnostic output was removed.

Merge Risk: ⚪ Minimal · up to 39941

The changes are localized crash fixes, and no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning No pull request description was provided, so the required issue reference, change summary, motivation, and checklist are missing. Add the required issue reference, a concise change summary and motivation, and complete each applicable checklist item.
Docstring Coverage ⚠️ Warning Docstring coverage is 42.86% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the target branch, score-media area, and primary purpose of fixing crashes.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@RomanPudashkin
RomanPudashkin requested a review from miiizen August 20, 2026 11:58
@DmitryArefiev

Copy link
Copy Markdown
Contributor

Tested on LinuxUbuntu26.04 LTS. No crashes found

@RomanPudashkin
RomanPudashkin merged commit dfc8b67 into musescore:4.7 Aug 20, 2026
14 checks passed
@RomanPudashkin
RomanPudashkin deleted the fix_score_media_crash_47 branch August 20, 2026 13:48
@github-project-automation github-project-automation Bot moved this from In Progress to Needs porting in MuseScore Studio 4.7.5 Aug 20, 2026
@RomanPudashkin RomanPudashkin moved this from Needs porting to Done in MuseScore Studio 4.7.5 Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants