Skip to content

📌 Pin scikit-build-core#1864

Merged
burgholzer merged 1 commit into
mainfrom
pin-scikit-build-core
Jul 7, 2026
Merged

📌 Pin scikit-build-core#1864
burgholzer merged 1 commit into
mainfrom
pin-scikit-build-core

Conversation

@denialhaag

Copy link
Copy Markdown
Member

Description

This PR pins scikit-build-core to ~=0.12 to prevent it from upgrading to version 1.0. The new version is incompatible with nanobind.stubgen. Once this issue is resolved, we can upgrade to 1.0 and benefit from the improved system for dynamic metadata. In particular, we should finally be able to drop our dependency on setuptools-scm.

Checklist

  • The pull request only contains commits that are focused and relevant to this change.
  • I have added appropriate tests that cover the new/changed functionality.
  • I have updated the documentation to reflect these changes.
  • I have added entries to the changelog for any noteworthy additions, changes, fixes, or removals.
  • I have added migration instructions to the upgrade guide (if needed).
  • The changes follow the project's style guidelines and introduce no new warnings.
  • The changes are fully tested and pass the CI checks.
  • I have reviewed my own code changes.

@denialhaag denialhaag self-assigned this Jul 6, 2026
@denialhaag denialhaag added dependencies Pull requests that update a dependency file python Anything related to Python code labels Jul 6, 2026
@denialhaag denialhaag requested a review from burgholzer July 7, 2026 16:58
@denialhaag

Copy link
Copy Markdown
Member Author

@burgholzer, do we also want to merge this here for now? As we don't have the problem with editable installs here, nanobind.stubgen is the only issue. We could also go with 67d21dd instead, at the cost of having diverging configurations across our repositories. 🤔

@burgholzer

Copy link
Copy Markdown
Member

@burgholzer, do we also want to merge this here for now? As we don't have the problem with editable installs here, nanobind.stubgen is the only issue. We could also go with 67d21dd instead, at the cost of having diverging configurations across our repositories. 🤔

Let's get this in here as well and fix everything consistently later

@burgholzer burgholzer merged commit bf4f00a into main Jul 7, 2026
27 checks passed
@burgholzer burgholzer deleted the pin-scikit-build-core branch July 7, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file python Anything related to Python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants