Skip to content

feat(feature-flags): turn insights-visual on for all users - #747

Merged
mthines merged 2 commits into
mainfrom
feat/insights-visual-on-for-all-users
Nov 9, 2026
Merged

mthines merged 2 commits into
mainfrom
feat/insights-visual-on-for-all-users

Conversation

@dash0-dev

@dash0-dev dash0-dev Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Turns the insights-visual flag on for every user of the LoreKit dashboard. The 50/50 experiment ends; the flag now defaults to on and stays as a kill switch, the same pattern retention-policies uses.

Changes

  • registry.ts: defaultVariant off → on, experiment block removed, experiment tag dropped, description rewritten (kill switch + how to retire it).
  • flags.manifest.json: regenerated (flags.generated.ts is unchanged — types don't carry defaults).
  • docs/feature-flags.md: no longer describes insights-visual as a running experiment; it stays the worked example in "Running an experiment".

Context

  • Every user now resolves to on with reason static. A developer override on /settings/developer still wins, so the original page can still be forced for one browser.
  • Turning it back off for everyone: set defaultVariant: 'off' and deploy.
  • feature_flag.exposed keeps firing from the InsightsView resolver, now with reason static, so experiment queries filtered on reason="split" stop counting new users.
  • User-facing docs: none needed — the public docs describe the delivered × chosen grid, which the visual page keeps.
  • Verified locally: gen-feature-flags.mjs --check in sync, feature-flags tests 62/62 pass. web typecheck/lint left to CI (data-only change, no generated type changed).

mthines and others added 2 commits November 9, 2026 10:58
Co-authored-by: dash0-dev[bot] <257284812+dash0-dev[bot]@users.noreply.github.com>
Co-authored-by: dash0-dev[bot] <257284812+dash0-dev[bot]@users.noreply.github.com>
@mthines
mthines marked this pull request as ready for review November 9, 2026 11:12
@mthines
mthines self-requested a review as a code owner November 9, 2026 11:12
@dash0-dev

dash0-dev Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor Author

Darkplane AutoMerge

Darkplane AutoMerge started approving this commit but did not finish, so it will not act on this commit again. Check the pull request reviews, then push a new commit or ask a human to approve.

@mthines
mthines merged commit d19b19f into main Nov 9, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant