Repository navigation
feat(feature-flags): turn insights-visual on for all users - #747
Merged
Merged
Conversation
Co-authored-by: dash0-dev[bot] <257284812+dash0-dev[bot]@users.noreply.github.com>
Co-authored-by: dash0-dev[bot] <257284812+dash0-dev[bot]@users.noreply.github.com>
mthines
marked this pull request as ready for review
November 9, 2026 11:12
mthines
approved these changes
Nov 9, 2026
Contributor
Author
|
Darkplane AutoMerge Darkplane AutoMerge started approving this commit but did not finish, so it will not act on this commit again. Check the pull request reviews, then push a new commit or ask a human to approve. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Turns the
insights-visualflag on for every user of the LoreKit dashboard. The 50/50 experiment ends; the flag now defaults toonand stays as a kill switch, the same patternretention-policiesuses.Changes
registry.ts:defaultVariantoff→on, experiment block removed,experimenttag dropped, description rewritten (kill switch + how to retire it).flags.manifest.json: regenerated (flags.generated.tsis unchanged — types don't carry defaults).docs/feature-flags.md: no longer describesinsights-visualas a running experiment; it stays the worked example in "Running an experiment".Context
onwith reasonstatic. A developer override on/settings/developerstill wins, so the original page can still be forced for one browser.defaultVariant: 'off'and deploy.feature_flag.exposedkeeps firing from theInsightsViewresolver, now with reasonstatic, so experiment queries filtered onreason="split"stop counting new users.gen-feature-flags.mjs --checkin sync,feature-flagstests 62/62 pass.webtypecheck/lint left to CI (data-only change, no generated type changed).