content dry-run の検証を本実行に近づける - #40
Merged
Merged
Conversation
mrmtsu
marked this pull request as ready for review
May 17, 2026 05:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
type: stringのヒントがある single select でも、["value"]形式を validate で落とさないようにしましたcontent create/update --dry-runで schema validation を行い、入力そのままのpayloadと本実行時に送るnormalizedPayloadを出力するようにしましたerror.detailsに含めるようにしました0.7.4に上げ、CHANGELOG / CHANGELOG.ja / README / README.ja に今回の挙動を追記しました背景
0.7.3 のフィードバックでは、validate / dry-run / 本実行で payload shape の期待値が一致せず、dry-run の
.ok == trueを信じたあとに本実行で 400 になるケースがありました。特に危なかったのは、dry-run が schema validation や本実行時の select 正規化を反映せず、単に入力 payload を表示して成功扱いにしていた点です。このPRでは、直接の
content create/update --dry-runを本実行に近い preflight に寄せています。確認
pnpm run check:cinpm run check:ciが成功