Java: Exclude JUnit test methods from log injection#24
Open
mrigankpawagi wants to merge 1 commit into
Open
Conversation
Methods annotated with JUnit test annotations (@test, @ParameterizedTest, @RepeatedTest, @testfactory from JUnit 5, or @test from JUnit 4) are excluded from log injection results. Test code intentionally logs user-controlled input for testing purposes and does not represent a security vulnerability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Excludes log injection results that occur within methods annotated with JUnit test annotations (
@Test,@ParameterizedTest,@RepeatedTest,@TestFactoryfrom JUnit 5, and@Testfrom JUnit 4).Problem
Test code frequently logs user-controlled test inputs for debugging purposes. These are not security vulnerabilities because:
MRVA showed many FPs in test classes across Java repositories.
Validation
Static analysis confirms that methods annotated with test annotations are only invoked by test frameworks, never in production paths.