JavaScript: Reduce FPs in missing-regexp-anchor for intentional partial matching#22
Open
mrigankpawagi wants to merge 1 commit into
Open
JavaScript: Reduce FPs in missing-regexp-anchor for intentional partial matching#22mrigankpawagi wants to merge 1 commit into
mrigankpawagi wants to merge 1 commit into
Conversation
When a regex with misleading anchor precedence is used with .test() and the unanchored alternatives are simple words (no dots/TLD patterns), it is likely an intentional partial match for role/type checking rather than a hostname validation bypass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Excludes unanchored regex patterns from the
js/regex/missing-regexp-anchorquery when they consist of simple word alternatives (no dots) used with.test()for role/type checking.Problem
The query flags patterns like
/admin|moderator|user/.test(role)as missing anchors. However, these are intentional partial matches for role/type checking - not hostname validation. The alternatives contain no dots (unlike hostname patterns), indicating they are not URL-related.Validation
The fix is conservative: it only excludes patterns where ALL alternatives are dot-free simple words AND the pattern is used with
.test(). Hostname-like patterns (containing dots) remain flagged.