C#: Add EF Core interpolated SQL methods as SQL injection sanitizers#21
Open
mrigankpawagi wants to merge 1 commit into
Open
C#: Add EF Core interpolated SQL methods as SQL injection sanitizers#21mrigankpawagi wants to merge 1 commit into
mrigankpawagi wants to merge 1 commit into
Conversation
Entity Framework Core's FromSqlInterpolated, ExecuteSqlInterpolated, and ExecuteSqlInterpolatedAsync methods properly parameterize interpolated string values. Arguments to these methods should not be flagged as SQL injection sinks since EF Core handles parameterization automatically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Adds Entity Framework Core's
FromSqlInterpolated,ExecuteSqlInterpolated, andExecuteSqlInterpolatedAsyncmethods as sanitizers for thecs/sql-injectionquery.Problem
EF Core's interpolated SQL methods (
FromSqlInterpolated, etc.) acceptFormattableStringparameters and automatically parameterize interpolated values. Despite using C# string interpolation syntax ($"SELECT * FROM Users WHERE Id = {id}"), these methods are NOT vulnerable to SQL injection because EF Core extracts interpolated values as SQL parameters. The query incorrectly flags these as injection vulnerabilities.Validation
This is documented EF Core behavior: https://learn.microsoft.com/en-us/ef/core/querying/sql-queries#passing-parameters. The
FormattableStringoverload ensures values are parameterized.