Java: Exclude internal logging from stack trace exposure#20
Open
mrigankpawagi wants to merge 1 commit into
Open
Java: Exclude internal logging from stack trace exposure#20mrigankpawagi wants to merge 1 commit into
mrigankpawagi wants to merge 1 commit into
Conversation
When a stringified stack trace flows into a logging framework method (SLF4J, Log4j, java.util.logging), it should not be considered as exposed to external users. This adds a barrier to prevent false positives where stack traces are properly logged internally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Adds a barrier in the
java/stack-trace-exposurequery for stack trace strings that flow into logging framework calls (SLF4J, Log4j, java.util.logging), preventing them from being flagged as exposed to users.Problem
The query flags stack traces that are logged internally (e.g.,
logger.error("Failed", e)) as information exposure. Internal logging to files or aggregation systems is not exposure to end users. This generates many false positives in applications that properly log exceptions for debugging while returning generic error messages to users.Validation
Static analysis confirms that logging framework calls write to internal log files/streams, not HTTP responses. The barrier is added at the configuration level so it only stops flow that would otherwise reach an HTTP response sink via a logging call.