Python: Add json.dumps() as XSS sanitizer#19
Open
mrigankpawagi wants to merge 1 commit into
Open
Conversation
The output of json.dumps() is JSON-formatted data that is typically returned with application/json Content-Type. Browsers do not render JSON responses as HTML, preventing XSS attacks. This eliminates false positives on JSON API endpoints.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Adds
json.dumps()as a sanitizer for thepy/reflective-xssquery.Problem
When user input is serialized via
json.dumps()and returned withContent-Type: application/json, browsers do not render it as HTML, making XSS impossible. Additionally,json.dumps()escapes characters like<,>,&in its output. The current query flags these patterns as reflected XSS vulnerabilities.Validation
JSON API endpoints that serialize user data with
json.dumps()and return JSON responses are a common pattern in Flask/Django APIs that the query incorrectly flags.