Java: Add URL.getHost() to SSRF host validation sanitizer#18
Open
mrigankpawagi wants to merge 1 commit into
Open
Java: Add URL.getHost() to SSRF host validation sanitizer#18mrigankpawagi wants to merge 1 commit into
mrigankpawagi wants to merge 1 commit into
Conversation
The existing host comparison sanitizer only recognized URI.getHost(). This extends it to also recognize java.net.URL.getHost() followed by an equals check, which is a common pattern for validating the target host before making a request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Extends the host comparison sanitizer in the
java/ssrfquery to also recognizejava.net.URL.getHost()in addition to the existingjava.net.URI.getHost()support.Problem
The existing SSRF query recognizes
URI.getHost()comparisons as sanitizers but missed the equivalentURL.getHost()pattern. Code that parses a URL withnew URL(input)and validatesurl.getHost().equals(allowedHost)was still flagged as vulnerable. BothURL.getHost()andURI.getHost()serve the same validation purpose.Validation
Static analysis confirms
java.net.URL.getHost()returns the same host string asjava.net.URI.getHost(), making it an equally valid sanitizer for SSRF.