JavaScript: Reduce FPs in incomplete-sanitization for bracket pair removal#17
Open
mrigankpawagi wants to merge 1 commit into
Open
JavaScript: Reduce FPs in incomplete-sanitization for bracket pair removal#17mrigankpawagi wants to merge 1 commit into
mrigankpawagi wants to merge 1 commit into
Conversation
The isDelimiterUnwrapper predicate now also handles cases where bracket
pairs are removed using regex patterns (e.g., s.replace(/{/, '').replace(/}/, '')),
not just string literals. This reduces false positives for display-oriented
bracket stripping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Extends the bracket/brace pair removal exclusion in the
js/incomplete-sanitizationquery to cover more display-formatting patterns where bracket removal is intentional.Problem
The query flags
.replace("[", "")and.replace("]", "")pairs used for display formatting (stripping brackets from array representations) as incomplete sanitization. These are not security-relevant sanitizers - they are display formatters.Validation
Static analysis confirms the pattern matches the existing
isDelimiterUnwrapperlogic but covers additional cases where the removal pattern is slightly different.