Python: Exclude dotted module paths from hardcoded credentials#16
Open
mrigankpawagi wants to merge 1 commit into
Open
Python: Exclude dotted module paths from hardcoded credentials#16mrigankpawagi wants to merge 1 commit into
mrigankpawagi wants to merge 1 commit into
Conversation
Strings matching the pattern of Python dotted module/class paths (e.g., 'django.contrib.auth.hashers.PBKDF2PasswordHasher') are not credentials. They are class references used in configuration settings like PASSWORD_HASHERS, AUTHENTICATION_BACKENDS, and MIDDLEWARE.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Excludes strings matching the pattern of Python dotted module/class paths (e.g.,
django.contrib.auth.hashers.PBKDF2PasswordHasher) from being considered as potential hardcoded credentials.Problem
The
py/hardcoded-credentialsquery flags Django settings likePASSWORD_HASHERSwhich contain dotted Python class paths as values. These are not credentials - they are module references. MRVA confirmed FPs on Django projects with settings likePASSWORD_HASHERS = ["django.contrib.auth.hashers.PBKDF2PasswordHasher"].Validation
The regex
[a-zA-Z_][a-zA-Z0-9_]*(\.[a-zA-Z_][a-zA-Z0-9_]*){2,}matches dotted paths with 3+ components, which are almost never actual credentials.