Python: Add Django safe_join as path injection sanitizer#15
Open
mrigankpawagi wants to merge 1 commit into
Open
Python: Add Django safe_join as path injection sanitizer#15mrigankpawagi wants to merge 1 commit into
mrigankpawagi wants to merge 1 commit into
Conversation
django.utils._os.safe_join validates that the resulting path stays within the base directory, preventing path traversal. This eliminates false positives when safe_join is used (e.g., in django/views/static.py).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Adds
django.utils._os.safe_joinas a sanitizer for thepy/path-injectionquery.Problem
Django's
safe_joinfunction validates that the joined path stays within the base directory by raising aSuspiciousFileOperationexception if traversal is detected. The current query flags code that usessafe_joinas vulnerable to path injection, which is a false positive.Validation
MRVA on top-100 Python repos showed FPs in django/views/static.py and similar Django view code that correctly uses
safe_join.