Editor: Fix ListboxItem text content.#33648
Open
Mugen87 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #32729
Description
The resource panel in the editor does not properly list textures because the listbox shows the
typeproperty of its items which has a different semantics in three.js classes though.Object3D,BufferGeometryorMaterialhold the object type butTexture.typedescribes the texture's data type so it holds values likeTHREE.UnsignedByteType. Hence, the texture panel lists now meaningless numbers:With this PR,
UIListboxusesitem.constructor.namewhich works for all objects.FYI: Using
item.constructor.namewould break if the editor uses the minified builds or is bundled but I'm not aware of another solution at the moment.Alternatively, we just remove the texture resource tab. You can't assign textures anyway so it's a plain list at the moment with no further functionality.