Skip to content
This repository was archived by the owner on Jan 29, 2025. It is now read-only.

Add schemaVersion property - #133

Merged
k88hudson merged 1 commit into
mozilla:mainfrom
k88hudson:version
Oct 15, 2020
Merged

Add schemaVersion property#133
k88hudson merged 1 commit into
mozilla:mainfrom
k88hudson:version

Conversation

@k88hudson

@k88hudson k88hudson commented Oct 1, 2020

Copy link
Copy Markdown
Contributor

Fixes #130. I thought maybe schemaVersion would be more specific about what it refers to.

See #135 for an ADR that discusses how this would be used.

@rfk rfk left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thanks!

@@ -1,4 +1,5 @@
{
"schemaVersion": "0.1.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I honestly can't imagine us using the patch version for anything useful, but I also have no objection to having it here, so 👍

@k88hudson
k88hudson merged commit 1b6b2a6 into mozilla:main Oct 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add "version" field to nimbus experiment schema?

2 participants