bug 2062403 - Allow 'subcategories' longer than 29 characters

CHANGELOG.md

@@ -3,6 +3,7 @@
 ## Unreleased
 
 - BREAKING CHANGE: Generate labeled {custom|memory|timing} distribution for mobile ([#857](https://github.com/mozilla/glean_parser/pull/857))
+- Allow categories to have subcategories longer than 29 characters ([bug 2062403](https://bugzilla.mozilla.org/show_bug.cgi?id=2062403))
 
 ## 20.2.0
 - Allow renaming of fields when serializing metrics ([mozilla/glean-dictionary#2309](https://github.com/mozilla/glean-dictionary/issues/2309))

glean_parser/schemas/metrics.2-0-0.schema.yaml

@@ -21,7 +21,7 @@ definitions:
 
   dotted_snake_case:
     type: string
-    pattern: "^[a-z_][a-z0-9_]{0,29}(\\.[a-z_][a-z0-9_]{0,29})*$"
+    pattern: "^[a-z_][a-z0-9_]{1,40}(\\.[a-z_][a-z0-9_]{1,39})*$"
     maxLength: 40
 
   event_extra_key:

tests/data/categories.yaml

@@ -0,0 +1,14 @@
+# Any copyright is dedicated to the Public Domain.
+# https://creativecommons.org/publicdomain/zero/1.0/
+
+---
+$schema: moz://mozilla.org/schemas/glean/metrics/2-0-0
+
+we_used_to_have_subcategory_length:
+  but_we_dont_any_more:
+    type: counter
+    expires: never
+    description: A test metric
+    bugs: [https://bugzil.la/2062403]
+    data_reviews: [https://www.example.com]
+    notification_emails: [glean-team@mozilla.com]

tests/test_parser.py

@@ -1593,3 +1593,14 @@ def test_overriden_expire_epoch_must_be_valid(invalid_epoch):
         list(all_metrics)
 
     del os.environ["SOURCE_DATE_EPOCH"]
+
+
+def test_categories():
+    """Test the basics of parsing oddly-named-or-structured categories."""
+    all_metrics = parser.parse_objects(
+        [ROOT / "data" / "categories.yaml"],
+        config={"allow_reserved": False},
+    )
+
+    errs = list(all_metrics)
+    assert len(errs) == 0