Skip to content

fix(pair): center the loading spinner on the supplicant connect screen - #21134

Open
dschom wants to merge 1 commit into
mainfrom
FXA-14457
Open

fix(pair): center the loading spinner on the supplicant connect screen#21134
dschom wants to merge 1 commit into
mainfrom
FXA-14457

Conversation

@dschom

@dschom dschom commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Because

  • On Android, the loading state shown just before /pair/supplicant/connect_this_device put its spinner in the upper-left corner of the page instead of the center.

This pull request

  • Renders the connect_this_device loading state through AppLayout's loading state, so the spinner is centered inside the same page chrome and card as the connect prompt that follows it.
  • Adds a container test asserting the spinner renders within the page layout while the pairing channel opens.

Issue that this pull request solves

Closes: FXA-14457

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).
  • I have manually reviewed all AI generated code.

How to review (Optional)

  • Key files/areas to focus on:
  • Suggested review order:
  • Risky or complex parts:

Screenshots (Optional)

image

Other information (Optional)

  • The bug was reported on Android, but the bare spinner had no centering on any platform — the fix is not platform-specific.
  • Pair2/Authority/ApproveSignIn/container.tsx has the same bare <LoadingSpinner /> on its own loading state. Left alone here as it is a different screen than the one this ticket covers; worth a follow-up ticket.

Because:

* The wait for the pairing channel rendered a bare spinner with no layout of
  its own, so it sat in the top-left corner instead of the middle of the page.

This commit:

* Renders the connect_this_device loading state through AppLayout so it keeps
  the page chrome and centering of the card that follows it.
* Adds a container test covering the loading state.

Fixes FXA-14457
@dschom
dschom marked this pull request as ready for review September 2, 2026 18:28
@dschom
dschom requested a review from a team as a code owner September 2, 2026 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant