Conversation
Because: * The wait for the pairing channel rendered a bare spinner with no layout of its own, so it sat in the top-left corner instead of the middle of the page. This commit: * Renders the connect_this_device loading state through AppLayout so it keeps the page chrome and centering of the card that follows it. * Adds a container test covering the loading state. Fixes FXA-14457
dschom
marked this pull request as ready for review
September 2, 2026 18:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
/pair/supplicant/connect_this_deviceput its spinner in the upper-left corner of the page instead of the center.This pull request
connect_this_deviceloading state throughAppLayout'sloadingstate, so the spinner is centered inside the same page chrome and card as the connect prompt that follows it.Issue that this pull request solves
Closes: FXA-14457
Checklist
Put an
xin the boxes that applyHow to review (Optional)
Screenshots (Optional)
Other information (Optional)
Pair2/Authority/ApproveSignIn/container.tsxhas the same bare<LoadingSpinner />on its own loading state. Left alone here as it is a different screen than the one this ticket covers; worth a follow-up ticket.