Conversation
Because:
- The live card's copy and its "Opening Firefox…" status line diverged
from the approved design and from the Pair2 storybook card.
- The design drops the separate store link; the hand-off already routes
to the store on both platforms.
This commit:
- Retitles the card "Get Firefox on this device" with the sync subcopy
and an inline "Learn more" link.
- Moves "Opening Firefox…" into the CTA as its active state.
- Removes the "Don’t have Firefox? Get it now" link.
- Keeps the CTA mounted throughout, so `attempting` alone drives it and
a retap still reaches the store.
Fixes FXA-14459
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Because:
- CodeQL reads `replace(/<\/?[a-zA-Z]+>/g, '')` as an incomplete HTML
sanitizer and fails the PR on a high-severity alert.
This commit:
- Splits the Fluent message on the literal `<linkExternal>` tag instead,
asserting the sentence and the placeable separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
longer matched the approved design — wrong heading and subcopy, no
"Learn more" link.
link beneath that, instead of as the button's own active state.
This pull request
sync explainer plus an inline "Learn more" link.
state.
attemptingalone drives it andctaRevealedgoes away.-v2Fluent ids for the two changed strings and drops the store-linkmessage.
Issue that this pull request solves
Closes: FXA-14459
Checklist
Put an
xin the boxes that applyHow to review (Optional)
packages/fxa-settings/src/components/ContinueInFirefox/index.tsxctaRevealedis gone, so the WebView backstop timer returns the CTA to rest rather than
revealing it.
Screenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
LINK.FX_SYNC, matching the Pair2Supplicant/DownloadFirefoxcard this ticket cites as the reference. Theticket names a SUMO pairing article instead — swap the target if design
prefers it.
iOS build where the error alert fires
visibilitychange, so the watchdogwrongly concludes the app opened. A retap re-arms it.
payments, crypto, session, or migration paths touched.