fix(settings): re-enable StrictMode and upgrade React to 19.2.8 - #21131
Draft
vpomerleau wants to merge 2 commits into
Draft
fix(settings): re-enable StrictMode and upgrade React to 19.2.8#21131vpomerleau wants to merge 2 commits into
vpomerleau wants to merge 2 commits into
Conversation
Because: - StrictMode was removed during the React 19 upgrade, leaving no dev-time guard against mount effects that are not idempotent. - Several of those effects held their once-guard in React state, which a second call in the same commit reads before the update lands. - The duplicate call then mints a second secret, code or ceremony that invalidates the one the user is looking at. This commit: - Scopes the passkey ceremony to each effect run and re-enables StrictMode. - Guards the 2FA backup codes, TOTP replace and passwordless code send. - Builds the settings context once so alert bar calls are not orphaned. - Records Glean view events once, keeping pings under the upload throttle. - Keeps the query string on the cookies_disabled redirect. Closes #FXA-14313
Because: - The 19.0.8 pin was a workaround for passkey and 2FA functional failures that no longer reproduce once the mount effects are idempotent. This commit: - Bumps react and react-dom from 19.0.8 to 19.2.8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
useGleanViewhook.cookies_disabledredirect.Issue that this pull request solves
Closes: FXA-14313
Checklist
Put an
xin the boxes that applyHow to review (Optional)
Screenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.