Conversation
bcolsson
approved these changes
Aug 26, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a Nimbus experiment for QR mobile-promo messaging and branch-specific attribution.
Changes:
- Adds nine experiment branches with localized headings and QR mappings.
- Redesigns the promo and expands Glean telemetry.
- Adds component tests and Storybook variants.
Reviewed changes
Copilot reviewed 11 out of 23 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
configs/nimbus.yaml |
Declares the experiment feature. |
packages/fxa-shared/metrics/glean/fxa-ui-metrics.yaml |
Defines telemetry extras. |
packages/fxa-shared/metrics/glean/web/index.ts |
Adds the branch event property. |
packages/fxa-shared/metrics/glean/web/promoQrMobile.ts |
Updates generated event typing. |
packages/fxa-settings/src/lib/glean/index.ts |
Forwards experiment telemetry. |
packages/fxa-settings/src/models/contexts/NimbusContext.ts |
Exports Nimbus context. |
packages/fxa-settings/src/components/PromoQrMobile/branches.ts |
Maps branches to copy and QR assets. |
packages/fxa-settings/src/components/PromoQrMobile/index.tsx |
Implements experiment rendering and reporting. |
packages/fxa-settings/src/components/PromoQrMobile/index.test.tsx |
Tests branches, visibility, and telemetry. |
packages/fxa-settings/src/components/PromoQrMobile/index.stories.tsx |
Adds visual branch scenarios. |
packages/fxa-settings/src/components/PromoQrMobile/en.ftl |
Adds localized experiment copy. |
packages/fxa-settings/src/components/PromoQrMobile/control.svg |
Adds the control QR asset. |
packages/fxa-settings/src/components/PromoQrMobile/treatment-b.svg |
Adds a treatment QR asset. |
packages/fxa-settings/src/components/PromoQrMobile/fox-body.svg |
Adds decorative artwork. |
packages/fxa-settings/src/components/PromoQrMobile/fox-tail.svg |
Adds decorative artwork. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+64
to
+68
| const cmsQr = | ||
| promoQrImageUrl && isValidCmsUrl(promoQrImageUrl) ? promoQrImageUrl : null; | ||
|
|
||
| const feature = experiments?.features?.['promo-qr-mobile']; | ||
| const enrolled = !cmsQr && feature?.['enabled'] === true; |
| GleanMetrics.promoQrMobile.view(); | ||
| GleanMetrics.promoQrMobile.view({ | ||
| event: { | ||
| nimbusUserId: experiments?.nimbusUserId, |
Comment on lines
+4416
to
+4421
| extra_keys: | ||
| nimbus_user_id: | ||
| description: Nimbus user ID | ||
| type: string | ||
| branch: | ||
| description: The value proposition experiment branch shown to the user |
|
|
||
| <FtlMsg id="promo-qr-mobile-description-v2"> | ||
| <p className="py-1 text-sm text-grey-900 dark:text-grey-100"> | ||
| Scan to download mobile app |
Comment on lines
+957
to
+959
| promoQrMobile.view.record({ | ||
| branch: gleanPingMetrics?.event?.['branch'] || '', | ||
| nimbus_user_id: gleanPingMetrics?.event?.['nimbusUserId'] || '', |
Because: - The mobile download rate from desktop auth traffic needs a lift, and no FxA Nimbus experiment has run before. - The updated promo design makes room for the longer headings the test needs. This commit: - Declares promo-qr-mobile in the FML with enabled and branch, typed as a BranchSlug enum so a misspelled arm is rejected instead of silently serving the control while Cirrus reports a treatment. - Adds 9 literal FTL heading ids and a per-branch QR, resolved at runtime. - Rebuilds the promo to the updated design: no logo, CTA below the QR, and real fox vectors in place of the 230KB kit. - Reports branch and nimbus_user_id on promo_qr_mobile.view, stamping the id the provider enrolled with rather than the value the API echoes back. - Holds the render until both Nimbus and the CMS resolve, so no control paints and then swaps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
promo-qr-mobilefeature inconfigs/nimbus.yamlwith two variables,enabledandbranch. Every channel defaults to the control, so a Cirrus failure is a no-opbranches.ts, mapping each branch slug to its heading and its own QR code. One slug drives both, because each QR scans to a distinct Bitly link and a mismatched pair would misattribute the download. An unknown slug falls back to the controlen.ftlso l10n extraction finds them, and picks one at runtime withuseFtlMsgResolver. The CTA moves below the QR and changes wording, so it takes a newpromo-qr-mobile-description-v2idindex.tsxto the updated design. Drops the logo above the heading, since the Bitly QR already embeds the Firefox glyph. Replaces the 230KBqr-mobile-kit.svgwithfox-body.svg,fox-tail.svg, and a per-branch QR, roughly a 10x reductionbranchandnimbus_user_idextra keys topromo_qr_mobile.view. Cirrus reports enrollment itself, so the app must stampnimbus_user_idon its own events for analysis to join themNimbusContextso tests and stories can supply a branch without a network fetchIssue that this pull request solves
Closes: https://mozilla-hub.atlassian.net/browse/FXA-14273
Checklist
Other information
npx jest src/components/PromoQrMobile: 52 passed, 0 failed.npx jest src/lib/glean src/models/contexts: 188 passed, 0 failed.How to test:
NIMBUS_ENABLED=truein the root.envand bring up infrastructure so thecirruspm2 process runsaccounts.cirrus, featurepromo-qr-mobile, 9 branches?nimbusPreview=trueat 1024px or wider, on/,/signin, or/signuppromo_qr_mobile.viewcarriesbranchandnimbus_user_idBranch records come from Remote Settings, so enrollment cannot be hand-authored locally. Storybook has
Control,TreatmentB, andTreatmentAstories covering 1, 2, and 3-line headings without a Nimbus fetch.Needs a decision before merge: the CTA reads "Scan to download mobile app" per the Figma design, but the ticket table says "Scan to get the app" in all 9 rows. The CTA is constant across branches so it does not confound the experiment, but it does change shipped copy in every branch including the control.
Needs data review: the two new Glean extra keys.