Bug 2075360 - #2764
Merged
Merged
Bug 2075360#2764
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The validation consistently blocks nonnumeric object IDs, and focused regression tests cover the vulnerable request paths.
Review effort: Balanced
Findings: None
What changed in this PR
Hardens REST object-ID handling against condition-hash injection.
Changes:
- Validates attachment and comment IDs as numeric before object loading.
- Adds regression coverage for affected PUT endpoints and valid numeric IDs.
| File | Description |
|---|---|
Bugzilla/WebService/Bug.pm |
Validates attachment and comment IDs. |
extensions/BugModal/lib/WebService.pm |
Validates BugModal comment IDs. |
qa/t/rest_bug_object_condition.t |
Tests malicious condition hashes and valid IDs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review+ carried over from private pull request
https://bugzilla.mozilla.org/show_bug.cgi?id=2075360