WIP: linux: add a 2 second read timeout for USB HID#360
Draft
micolous wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress, do not merge yet!
Adds a 2 second
read()timeout for USB HID on Linux.Background
A bunch of projects exist that extend
authenticator-rs' transport support by usinguhid(and similar) to simulate a USB HID authenticator.Unfortunately, some of these transports are less reliable than USB, and simulated devices may not even send
CTAPHID_KEEPALIVEas frequently as suggested by the spec (100 ms). A misbehaving device can cause an application using this library to hang, potentially indefinitely.I've written a tester for Linux which looks like a USB HID authenticator but never responds sends any replies, which causes
authenticator_rsand (current) Firefox to hang: https://github.com/micolous/webauthn-toys/tree/main/fido_tarpitThis applies a 2 second timeout on all USB HID reads on Linux. Authenticators can still respond with
CTAPHID_KEEPALIVEbefore this timeout, and get extra time. Applications can still pass akeep_aliveparameter to impose further deadlines.Potentially fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1958831
TODO (for me)
I suspect an authenticator could stall indefinitely by sending
CTAPHID_KEEPALIVEin response toCTAPHID_INIT. To test this, I'm planning to add a flag tofido_tarpitthat responds to any command withCTAPHID_KEEPALIVE.Then I'll look at only allowing
CTAPHID_KEEPALIVEforCTAPHID_CBORandCTAPHID_MSG(per spec), and test this against some authenticators in my collection.