Repository navigation
fix: adds request_spoc_or_image_ads to fix deserialization error - #7663
Conversation
| // Use staging client, because this does not use a mock placement_id. | ||
| let client = staging_client(); | ||
|
|
||
| // Note: this particular return is due to a bug with `newtab_stories_1`- it returns 3 ads, but only two of which are spoc. |
There was a problem hiding this comment.
Originally I had a part of this test that checked there were two ads for request_spoc_ads for the same placement, but that failed, making me think that this is somewhat stochastic on the MARS side of whether a combined set of ads are sent.
If so, this test as it is now will sometimes have false successes, rather than any false failures.
There was a problem hiding this comment.
somewhat stochastic
Confirming the response is dependent on what inventory is registered in the staging ad server. If inventory isn't running then this may not return 3 ads too.
There was a problem hiding this comment.
Good point. Unless we have a mock placement then for this specific case, we can't make a test that really works for this. In that case, I'll delete this test.
…into AC-221-adds-request_spoc_or_image_ads
3 participants
Pull Request checklist
[ci full]to the PR title.