Repository navigation
Conversation
Draft
7 tasks
Member
Author
|
pushing a new version of this:
|
mhammond
force-pushed
the
push-psxrrxxoklrt
branch
from
October 14, 2026 12:25
219fb0f to
21817a8
Compare
Contributor
@mhammond Do you expect you'll need to make additional changes to this PR? If so it might make sense for Robin and I to pivot to other work in the meantime. @bytesized |
mhammond
force-pushed
the
push-psxrrxxoklrt
branch
3 times, most recently
from
October 15, 2026 12:02
59d90d8 to
4bcfa7f
Compare
Member
Author
|
oops, I think I pushed a badly rebased version of this; updated to just be simple type changes and no logic - I think it's looking good to land. I linked an Android fix, and iOS will need to update where current options are listed. Once we have r+ everywhere we can talk to relman and land them all 🤞 |
…c engine choices
SyncParams.enabled_changes becomes SyncParams.engine_choices_model:
EngineChoicesModel::Account { enabled_changes } keeps today's behaviour, and
EngineChoicesModel::Device selects per-device engine choices.
DeviceSettings gains enabled_engines, the engines this device syncs, which is
passed through to the clients engine's Settings so it can later be published
for other devices on the account.
mhammond
force-pushed
the
push-psxrrxxoklrt
branch
from
October 15, 2026 13:35
4bcfa7f to
23f6c42
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is towards allowing per-device or per-account settings, driven by the app - a replacement for #7611. This is a breaking change: