Repository navigation
Use UTC for the commit date in bug titles, and say so - #427
Open
tomrittervg wants to merge 1 commit into
Open
tomrittervg wants to merge 1 commit into
tomrittervg wants to merge 1 commit into
Conversation
Hosts report the upstream commit time differently: gitlab and codeberg give the committer's local time with an offset, github gives UTC, and googlesource gives UTC with no zone. We dropped the offset, so titles showed the committer's wall-clock time (libgbm's 02:59 UTC commit was titled 12:59). Convert to UTC and append "UTC" to the title.
There was a problem hiding this comment.
🟢 Approval recommended
The focused conversion and title changes have regression coverage and no identified blocking issues.
0 open findings
What changed in this PR
Normalizes upstream commit timestamps to UTC so Bugzilla update titles show consistent, explicitly labeled times across hosts.
Changes:
- Converts timezone-aware timestamps to UTC.
- Adds “UTC” to update titles.
- Covers positive and negative offsets, including date rollover.
| File | Description |
|---|---|
| tests/mach_vendor.py | Adds offset conversion and date rollover tests. |
| tests/bugzilla.py | Updates the expected title with UTC time and label. |
| components/utilities.py | Converts timezone-aware dates to UTC before formatting. |
| components/bugzilla.py | Appends “UTC” to update titles. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hosts report the upstream commit time differently: gitlab and codeberg give the committer's local time with an offset, github gives UTC, and googlesource gives UTC with no zone. We dropped the offset, so titles showed the committer's wall-clock time (libgbm's 02:59 UTC commit was titled 12:59). Convert to UTC and append "UTC" to the title.