fix(web): show real PM webhook callback URL in Trello/JIRA wizard#1401
Merged
zbigniewsobiecki merged 2 commits intoJun 12, 2026
Merged
Conversation
The Trello and JIRA webhook steps displayed `${origin}/webhooks/<project>/<provider>`
as the webhook URL, but the router serves `/<provider>/webhook` and the actual
registered callback (and the curl example) is `${callbackBaseUrl}/<provider>/webhook`.
The displayed URL and the real callback diverged, so operators copying the shown
URL pointed Trello/JIRA at a path the router never handles (it falls through to the
dashboard SPA). Derive the displayed `webhookUrl` from `callbackBaseUrl` with the
correct `/<provider>/webhook` suffix so the wizard shows exactly what gets
registered. Linear already used the correct `${routerOrigin}/linear/webhook` form.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Trello and JIRA webhook wizard steps displayed the webhook URL as
${origin}/webhooks/<project>/<provider>, but:/<provider>/webhook(e.g./trello/webhook), not/webhooks/<project>/<provider>.${callbackBaseUrl}/<provider>/webhook.So the displayed URL and the real callback diverged. An operator copying the shown URL points the provider at a path the router never handles — it falls through to the dashboard SPA (returns the HTML app, not the webhook handler), so deliveries silently go nowhere. This was hit live while configuring a Trello integration behind a Cloudflare tunnel.
Fix
Derive the displayed
webhookUrlfromcallbackBaseUrlwith the correct/<provider>/webhooksuffix, so the wizard shows exactly what gets registered.trello/wizard.ts:webhookUrl = callbackBaseUrl ?${callbackBaseUrl}/trello/webhook: ''jira/wizard.ts:webhookUrl = callbackBaseUrl ?${callbackBaseUrl}/jira/webhook: ''callbackBaseUrlis computed (it was referenced before definition otherwise).Linear already used the correct
${routerOrigin}/linear/webhookform — no change needed.Notes
Display-only change; the actual create/delete mutations already used
callbackBaseUrl+/<provider>/webhookserver-side, so previously-created webhooks are unaffected. Lint + typecheck pass.🤖 Generated with Claude Code