You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Documents the operation names that drivers report for tracing and server selection logging, and why some differ from the underlying server commands. Adds unified tests for both features.
Completes the covered-operations table with previously missing operations.
Corrects incorrect entries in the covered-operations table.
Specifies that server selection logging reports the same operation names as tracing.
Adds unified tests for the tracing operation names.
Adds unified tests for the server selection logging operation names.
operations
Document how the reported operation names relate to the underlying server
commands, complete the OpenTelemetry covered-operations table, and specify
that server selection logging reports the same operation names. Add six
tracing unified tests (schema 1.27), two server selection logging tests
(schema 1.14), and their generated JSON.
operations
Document how the reported operation names relate to the underlying server
commands, complete the OpenTelemetry covered-operations table, and specify
that server selection logging reports the same operation names. Add six
tracing unified tests (schema 1.27), two server selection logging tests
(schema 1.14), and their generated JSON.
Each unified test case recreates the client, and expected log messages are matched exactly. Unlike the first case, this and the following cases do not wait for primary discovery, so an extra Waiting for suitable server to become available message can make them fail nondeterministically. Add the readiness waitForEvent to every test before its first driver operation.
Wait for topology readiness before each test operation
Each unified test case gets a newly created client, and log matching rejects extra messages. Only the first case waits for topology discovery, so this case and every later one can emit Waiting for suitable server to become available between the expected started/succeeded messages. Add the same readiness waitForEvent used by the first case to each subsequent test before invoking the operation.
The rename target is not included in initialData, so on a fresh database the first operation tries to drop a nonexistent test1; drivers that surface NamespaceNotFound will stop before reaching the rename and span assertions. Seed the target collection here (as the existing create_collection.yml fixture does), or otherwise make the cleanup tolerate a missing collection.
The createCollection and renameCollection cases later drop created-collection and renamed-collection, but neither target is seeded here. On a fresh database those cleanup operations can raise NamespaceNotFound and prevent the operation-name assertions from running. Seed both target collections, following the existing collection-management fixtures.
🧠 Review effort: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRIVERS-3625
Documents the operation names that drivers report for tracing and server selection logging, and why some differ from the underlying server commands. Adds unified tests for both features.
Please complete the following before merging:
clusters)