Skip to content

fix(NODE-7666): correct metadata truncation order - #5125

Draft
johnmtll wants to merge 1 commit into
NODE-7666/environment-variables-in-the-handshake-metadatafrom
NODE-7666/NODE-7851/correct-metadata-truncation-order
Draft

johnmtll wants to merge 1 commit into
NODE-7666/environment-variables-in-the-handshake-metadatafrom
NODE-7666/NODE-7851/correct-metadata-truncation-order

Conversation

@johnmtll

Copy link
Copy Markdown
Contributor
  1. Orders os.type before platform, since it's not a documented truncatable.
  2. Name is appended after os.type
  3. OS is appended after name
  4. Agent is appended after OS
  5. The rest of env is appended after Agent

Description

Summary of Changes

Notes for Reviewers

What is the motivation for this change?

For bug fixes

Current (incorrect) behavior:

Expected behavior:

How to reproduce:

Affected versions:

Release Highlight

Release notes highlight

Double check the following

  • Lint is passing (npm run check:lint)
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

1. Orders os.type before platform, since it's not a documented
truncatable.
2. Name is appended after os.type
3. OS is appended after name
4. Agent is appended after OS
5. The rest of env is appended after Agent
@evergreen-ci-prod

Copy link
Copy Markdown

There is an existing patch(es) for this commit SHA:

Please note that the status that is posted is not in the context of this PR but rather the (latest) existing patch and that may affect some tests that may depend on the particular PR. If your tests do not rely on any PR-specific values (like base or head branch name) then your tests will report the same status. If you would like a patch to run in the context of this PR and abort the other(s), comment 'evergreen retry'.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant