Skip to content

PYTHON-6236 Ignore for git blame - #3192

Merged
NoahStapp merged 5 commits into
mongodb:mainfrom
NoahStapp:PYTHON-6236
Nov 11, 2026
Merged

NoahStapp merged 5 commits into
mongodb:mainfrom
NoahStapp:PYTHON-6236

Conversation

@NoahStapp

Copy link
Copy Markdown
Contributor

PYTHON-6236

Changes in this PR

Ignore the changes in #3190 for git blame.

Test Plan

Checklist

Checklist for Author

  • Did you update the changelog (if necessary)?
  • Is there test coverage?
  • Is any followup work tracked in a JIRA ticket? If so, add link(s).

Checklist for Reviewer

  • Does the title of the PR reference a JIRA Ticket?
  • Do you fully understand the implementation? (Would you be comfortable explaining how this code works to someone else?)
  • Is all relevant documentation (README or docstring) updated?

@NoahStapp
NoahStapp requested a review from a team as a code owner November 9, 2026 20:54
@NoahStapp
NoahStapp requested review from aclark4life and a balanced review from Copilot November 9, 2026 20:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the blame-exclusion and test-annotation updates.

No open issues 🎉

What changed in this PR

Excludes the Ruff B905 changes from PR #3190 from git blame, helping preserve useful line attribution in PyMongo. Also modernizes two test annotations without changing runtime behavior.

Changes:

  • Adds the B905 commit to .git-blame-ignore-revs.
  • Replaces Optional[BaseException] with BaseException | None in asynchronous and mirrored synchronous tests.
File Description
test/​test_periodic_executor.py Updates the mirrored synchronous test annotation.
test/​asynchronous/​test_periodic_executor.py Updates the asynchronous test annotation.
.git-blame-ignore-revs Adds the Ruff B905 commit to blame exclusions.

Review effort: Balanced

@NoahStapp
NoahStapp merged commit e11cd0b into mongodb:main Nov 11, 2026
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants