PYTHON-6117 Remove cyclic object reference between _ClientReadCheckou… - #3058
Merged
Merged
Conversation
…t and _PoolCheckout
7 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Async cleanup can raise or be cancelled before the cycle-breaking assignment executes.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Removes the client/pool checkout reference cycle after context-manager cleanup.
Changes:
- Clears
_pool_checkoutin synchronous and asynchronous clients.
| File | Description |
|---|---|
pymongo/synchronous/mongo_client.py |
Breaks the checkout cycle on sync exit. |
pymongo/asynchronous/mongo_client.py |
Breaks the checkout cycle on async exit. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+2755
to
+2757
| if self._pool_checkout is not None: | ||
| await self._pool_checkout.__aexit__(exc_type, exc_val, exc_tb) | ||
| self._pool_checkout = None # to break the reference cycle |
Contributor
Author
There was a problem hiding this comment.
did this change myself so i could run synchro and port it over to the sync file too :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…t and _PoolCheckout
PYTHON-6117
Changes in this PR
Test Plan
Checklist
Checklist for Author
Checklist for Reviewer