Evergreen by rozza · Pull Request #2012 · mongodb/mongo-java-driver

rozza · 2026-07-09T09:27:08Z

Various build fixes for evergreen.

GPG path handling - windows builds.
8.2 fix MQL asString version - windows builds (the only tests run against 8.2 MongoDB)
Added a default OS - OIDC failure and Publish Snapshots
Updated Sync shutdown hook - Caused Netty failures.

rozza · 2026-07-09T09:27:21Z

Patch build:
https://spruce.corp.mongodb.com/version/6a4f68b2519e62000703755f/tasks

nhachicha · 2026-07-09T13:43:48Z

+
+        // Run gpg capturing both streams; on non-zero exit throw with the captured output appended so the
+        // underlying gpg diagnostic is visible instead of Gradle's opaque "finished with non-zero exit value N".
+        fun runGpg(vararg args: String, onFailure: (String) -> String) {


Copilot

Pull request overview

This PR applies a set of Evergreen/CI robustness fixes, primarily targeting Windows-host differences (GPG path semantics and environment detection) and reducing shutdown-time test flakiness, while also adjusting MQL asString functional tests to align with server-version behavior.

Changes:

Update mongodb-crypt tarball signature verification to translate Windows paths for Cygwin gpg and improve error diagnostics.
Adjust MQL asString nested conversion tests to use 8.3 as the version boundary.
Harden Evergreen environment setup and sync test shutdown cleanup to avoid failures from missing env vars / shutdown-time exceptions.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
`mongodb-crypt/build.gradle.kts`	Adds Windows/Cygwin-aware GPG path translation and improved GPG exec diagnostics for libmongocrypt signature verification.
`driver-sync/src/test/functional/com/mongodb/client/Fixture.java`	Wraps shutdown-hook database drop in a try/catch to prevent shutdown-time failures.
`driver-core/src/test/functional/com/mongodb/client/model/mql/TypeMqlValuesFunctionalTest.java`	Shifts `asString` nested test gating from 8.2 to 8.3 to match server behavior.
`.evergreen/setup-env.bash`	Defaults `OS` when unset to avoid `set -u` unbound variable failures, improving cross-platform behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

rozza · 2026-07-09T14:51:56Z

FYI A number of tests (timing related) seem to be struggling with windows. Reviewing.

The gpg on the Evergreen Windows hosts is a Cygwin build that only understands POSIX paths. Handed native Windows paths (C:\dir) it treats them as relative, mangles the keyring location, and fails to find a writable keyring. Translate drive-letter paths to the Cygwin form (C:\dir -> /cygdrive/c/dir) on Windows for every gpg path argument (homedir, public key, signatures, tarballs); other platforms are unchanged. Also surface gpg stdout/stderr and the gnupgHome/publicKey state on failure so future gpg issues are diagnosable instead of showing only Gradle's opaque non-zero exit value.

Should fix publishing of snapshots. JAVA-6057

Brings it inline with the reactive streams shutdown hook. Ensures tests don't fail on shutdown with a DatabaseDropPending exception

CSOT prose and unified tests are calibrated for fast Linux CI hosts; on Windows + TLS a fresh client's connection establishment consumes the tight timeout budgets, so a command under test times out during setup (or the wrong command times out). Add ClusterFixture.isWindows()/scaleForWindows() plus a unified scaleForWindows(entities, definition, factor) transform, and apply Windows-only timeout scaling (and a value-agnostic floor for the success-family getMore-refresh tests) to the affected CSOT tests. The non-Windows RTT retries are retained for other TLS runs. All Windows CSOT adjustments are grouped at the end of the CSOT section.

…ationTimeoutException With timeoutMS set, socket timeouts should surface as MongoOperationTimeoutException. The read path translates a bare java.net.SocketTimeoutException, but the write path only handled MongoSocketWriteTimeoutException, so a bare SocketTimeoutException during a send fell through to MongoSocketWriteException. On Windows + TLS a blocking SSLSocket write surfaces the socket read-timeout as a bare SocketTimeoutException, reproducing the inconsistency. In throwTranslatedWriteException, when timeoutMS is set, wrap a bare SocketTimeoutException in a MongoSocketWriteTimeoutException and then MongoOperationTimeoutException, mirroring translateReadException. Confined to the timeoutMS path.

rozza · 2026-07-27T10:26:45Z

@nhachicha @vbabanin This is ready for review!

Note the evergreen failures are related to: SERVER-132246 (see #dbx-devs).

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.

Comments suppressed due to low confidence (2)

mongodb-crypt/build.gradle.kts:187

On Windows, drive.lowercase() is locale-sensitive (e.g., Turkish locale turns I into a dotless ı), which can produce an invalid /cygdrive/<drive>/... path for some drive letters. Use Locale.ROOT for deterministic ASCII lowercasing.

            return "/cygdrive/${drive.lowercase()}/${rest.replace('\\', '/')}"

driver-sync/src/test/functional/com/mongodb/client/unified/UnifiedTestModifications.java:258

Same as above: use ClusterFixture.WINDOWS_CSOT_TIMEOUT_MULTIPLIER instead of duplicating 10, so the factor stays consistent across all Windows-scaling transforms.

        def.transform("JAVA-6057: retryable CSOT tests cannot populate minPoolSize under the tight client-level "
                        + "timeoutMS on the slower Windows TLS hosts, where background connection establishment "
                        + "exceeds the timeout",
                (entitiesArray, definition) -> scaleForWindows(entitiesArray, definition, 10))
                .when(ClusterFixture::isWindows)
                .file("client-side-operations-timeout", "timeoutMS behaves correctly for retryable operations");

- Restore the `whenFailureContains("timeout")` predicate on the tailable non-awaitData retry, which was dropped when the retry block was moved. Without it the test was retried on any failure, not just timeout flakes. - Fix the Javadoc link to ClusterFixture#scaleForWindows(int) (was `long`). - Use ClusterFixture.WINDOWS_CSOT_TIMEOUT_MULTIPLIER instead of a hard-coded 10 in the unified transforms, so the prose and unified scaling cannot diverge. - Narrow the shutdown-hook catch in Fixture from Exception to MongoException and log the ignored failure rather than swallowing it silently.

rozza · 2026-07-27T11:20:24Z

Windows Evergreen build: https://spruce.corp.mongodb.com/version/6a673ec35539fb00075e9338

rozza marked this pull request as ready for review July 9, 2026 12:44

rozza requested a review from a team as a code owner July 9, 2026 12:44

rozza requested review from nhachicha and vbabanin July 9, 2026 12:44

nhachicha reviewed Jul 9, 2026

View reviewed changes

nhachicha requested a review from Copilot July 9, 2026 14:19

Copilot started reviewing on behalf of nhachicha July 9, 2026 14:19 View session

Copilot AI reviewed Jul 9, 2026

View reviewed changes

Comment thread mongodb-crypt/build.gradle.kts

rozza force-pushed the evergreen branch 2 times, most recently from a310f10 to 5398b95 Compare July 22, 2026 16:32

rozza marked this pull request as draft July 23, 2026 09:15

rozza force-pushed the evergreen branch from 5398b95 to ad4a749 Compare July 23, 2026 09:15

rozza added 6 commits July 23, 2026 10:17

Fix server version checking for nested MQL asString.

41f2f1e

Set a default OS in setup-env.bash

3be153f

Should fix publishing of snapshots. JAVA-6057

Ignore drop errors in the shutdown hook.

470aee3

Brings it inline with the reactive streams shutdown hook. Ensures tests don't fail on shutdown with a DatabaseDropPending exception

rozza force-pushed the evergreen branch from ad4a749 to b75082f Compare July 23, 2026 09:22

rozza marked this pull request as ready for review July 27, 2026 10:24

rozza requested a review from Copilot July 27, 2026 10:25

Copilot started reviewing on behalf of rozza July 27, 2026 10:26 View session

Copilot AI reviewed Jul 27, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Evergreen - #2012

Evergreen#2012
rozza wants to merge 7 commits into
mongodb:mainfrom
rozza:evergreen

rozza commented Jul 9, 2026

Uh oh!

rozza commented Jul 9, 2026

Uh oh!

Uh oh!

nhachicha Jul 9, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

rozza commented Jul 9, 2026

Uh oh!

rozza commented Jul 27, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rozza commented Jul 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

rozza commented Jul 9, 2026

Uh oh!

rozza commented Jul 9, 2026

Uh oh!

Uh oh!

nhachicha Jul 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

rozza commented Jul 9, 2026

Uh oh!

rozza commented Jul 27, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rozza commented Jul 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants