Repository navigation
fix(server): resolve minimatch DoS advisory via npm override - #28
Merged
Merged
Conversation
Dependabot alert #361 (GHSA-g3hv-75wg-m249, medium): minimatch <11.0.1 has a denial-of-service via globparts amplification. typescript-eslint@8.72.2 pins its own minimatch dependency to ^10.2.2, which never resolves to the patched 11.x line, so `npm audit fix` cannot reach it. Add an npm `overrides` entry forcing minimatch to ^11.0.1 across the server workspace; it dedupes to 11.0.8, already used elsewhere in the tree by eslint's @eslint/config-array. minimatch is a dev-only dependency here (ESLint tooling), never shipped or run in production. Verified lint, build, and the integration test suite all still pass after the override, and `npm audit` now reports 0 vulnerabilities. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Dependabot alert #361.
Vulnerability
minimatch>=7.0.0 <11.0.111.0.1typescript-eslint@8.72.2 -> @typescript-eslint/typescript-estree@8.72.2 -> minimatch@10.2.6(dev-only, ESLint tooling)Why
npm audit fixcouldn't resolve it@typescript-eslint/typescript-estreepins its own minimatch dependency to^10.2.2, which never resolves to the patched 11.x line — there's currently no stabletypescript-eslintrelease whose declared range reaches 11.0.1.Fix
Added an npm
overridesentry inserver/package.jsonforcingminimatchto^11.0.1regardless of the nested package's declared range:It dedupes to
minimatch@11.0.8, which is already present in the same tree viaeslint's@eslint/config-array, so this doesn't introduce a new major version to the install — it just stops two copies of the same library from diverging.minimatchis a dev-only dependency (ESLint), never shipped or run in production, so the override carries no runtime risk.Verification
npm ls minimatch— single deduped11.0.8resolution everywherenpm run test(server lint) — passesnpm run build(tsc) — passesnpm run test:integration— 2/2 tests passnpm audit— 0 vulnerabilities🤖 Generated with Claude Code