Fix critical false-negative on failed scans and align docs/packaging - #1
Merged
Merged
Conversation
Code: - cli: a scan that cannot run (unreachable target / no payloads) now prints the error and exits 2 instead of rendering a misleading "MINIMAL RISK" clean report with exit 0. - analyzer/scorer: add `from __future__ import annotations` so the package imports on Python 3.8 (re.Pattern[str] / dict[...] annotations were 3.9+). - engine: count flagged payloads per-payload so `failed_attacks` can no longer go negative when a payload yields multiple findings. Docs / project hygiene: - Standardise payload count to 36 (CLI info said 25+, README said 35+). - Add docs/API.md (README linked to a missing file) and drop the missing HTML-report screenshot embed. - Add .github/workflows/ci.yml running the suite on Python 3.8-3.12, making the documented CI pipeline real; add 3.12 classifier. - Add a Python .gitignore. - Add tests/test_cli.py covering the failed-scan exit path and info output. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JTQie52FfmeY1wwDvn8XF2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code:
from __future__ import annotationsso the package imports on Python 3.8 (re.Pattern[str] / dict[...] annotations were 3.9+).failed_attackscan no longer go negative when a payload yields multiple findings.Docs / project hygiene:
Claude-Session: https://claude.ai/code/session_01JTQie52FfmeY1wwDvn8XF2