Repository navigation
Add pion 1.1.0 (built from source, open kernels only) - #451
Merged
Merged
Conversation
Collaborator
|
thank you @pavelhorak ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Pion 1.1.0 server, a Redis-compatible key-value store written in Mojo, built entirely from source under Apache-2.0.
An earlier recipe (#391) was closed because it linked Pion's closed vector library. This one does not: it compiles the open reference vector kernels from
src/vector/reference/, as Pion'sbuild-opentask does, and its test fails if the closed library is linked. Pion's own release tarballs and Homebrew formula link the closed library, which returns the same results, faster, for 1536-dim vector search. Nothing else differs.Recipe (
recipes/pion/):v1.1.0tag archive (sha256e71259cc…3116).commitstamps the tag's commit into--version, as the release binaries do.build.shcompiles Pion's C shims and Lua, thenmojo build -O3with a pinned target CPU (apple-m1,x86-64-v2,neoverse-n1). The Metal shader for--metal-attentionis optional: it needs full Xcode, and without it that flag reports NOT ACTIVE.mojo-compiler ==1.2.0is also a run requirement:pion-serverloadslibKGENCompilerRTSharedand two libraries it pulls in from the compiler package.test_server.shchecks--version(the version, and that the closed library is not linked), starts the server on a random port, and runs Pion's wire basics (tests/test_raw.py) and a 1536-dim recall check (tests/test_vector_recall_smoke.py).Tested: osx-arm64 built and passed its tests with rattler-build 0.30 and this repository's channels and variants. Linux was not built with rattler-build here. Pion's CI builds and tests the same source on x86-64 and arm64, but with the closed library linked; the open build has no Linux CI job.