Repository navigation
feat: mark whether a project was auto approved or not - #8343
mergify[bot] merged 4 commits into
Conversation
Pull request changelogAppAddedChangedDeprecatedRemovedFixedSecurityWebsiteAddedChangedDeprecatedRemovedFixedSecurityHostingAddedChangedDeprecatedRemovedFixedSecurity |
|
Queue requested — the merge queue status continues in this comment ↓. |
[Medium impact] The change affects how project approval history is stored in the backend. The spacing requirement must be satisfied before merging; no behavioral defect was found.
|
| SET status = $1, | ||
| approved_because = CASE | ||
| WHEN approved IS NULL THEN 'auto' | ||
| ELSE approved_because | ||
| END, | ||
| approved = COALESCE(approved, NOW()) |
There was a problem hiding this comment.
The added SQL lines in try_auto_approve use tabs, but the backend guide requires spaces. This repository requirement must be satisfied before merging. Replace the tabs with spaces and refresh the matching SQLx cache, since changing query whitespace changes its hash.
Context Used: apps/labrinth/AGENTS.md (source)
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/labrinth/src/routes/v3/projects/mutation.rs
Line: 97-102
Comment:
**Added SQL uses tabs**
The added SQL lines in `try_auto_approve` use tabs, but the backend guide requires spaces. This repository requirement must be satisfied before merging. Replace the tabs with spaces and refresh the matching SQLx cache, since changing query whitespace changes its hash.
**Context Used:** apps/labrinth/AGENTS.md ([source](https://github.com/modrinth/code/blob/main/apps/labrinth/AGENTS.md))
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
There was a problem hiding this comment.
we use a mix of tabs and spaces in SQL migrations so it's not worth fixing atp
There was a problem hiding this comment.
Fair point—the SQL block follows the surrounding query style, and its mixed indentation alone isn’t worth a review comment. I shouldn’t have framed this as a required fix. Should I remember not to flag mixed indentation in embedded SQL when it matches the local query style?
There was a problem hiding this comment.
add this to memory
There was a problem hiding this comment.
Added the rule: “Do not flag mixed tabs and spaces in embedded SQL when the indentation matches the surrounding query style.” View rule
|
@Mergifyio queue |
✅ Merged into
|
No description provided.