Skip to content

refactor: skin rendering perf changes - #8330

Merged
mergify[bot] merged 10 commits into
mainfrom
cal/skin-rendering-rust
Nov 17, 2026
Merged

mergify[bot] merged 10 commits into
mainfrom
cal/skin-rendering-rust

Conversation

@IMB11

@IMB11 IMB11 commented Nov 14, 2026 •

Copy link
Copy Markdown
Member
  • Stops batch rendering skin cards using three.js
  • Introduces modrinth-skin-rendering crate.
  • Stores the batch renders in the app dir's caches folder rather than in-memory using IndexedDB
  • Drastically speeds up batch rendering to 20-30ms per skin.
  • ditch tres.js and just use three.js native

  • profile memory changes

@IMB11

IMB11 commented Nov 14, 2026

Copy link
Copy Markdown
Member Author

@greptileai review

@github-actions

Copy link
Copy Markdown
Contributor

Pull request changelog

App

Added

Changed

Deprecated

Removed

Fixed

Security

Website

Added

Changed

Deprecated

Removed

Fixed

Security

Hosting

Added

Changed

Deprecated

Removed

Fixed

Security

@greptile-apps

greptile-apps Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5 Tier: plus

[Medium impact] Appears safe to merge, with two non-blocking memory-cleanup issues in live skin previews.

Summary

Moves skin-card and head rendering into the new Rust modrinth-skin-rendering crate.

  • Skin cards and account avatars load cached images drawn by the app.
  • Interactive skin previews render through a directly managed Three.js canvas.
  • Interactive previews add Ears features using data decoded by the app.

The earlier cache-pruning and story threads were manually resolved by IMB11 without explanatory replies. Both threads were unnumbered.

Validation was source-only. No app, Storybook, or tests were run.

Reviews (2) · Last reviewed commit: "fix: rev" · Reviewed by Greptile

@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Frontend previews

Last deployed commit is 45ed5d254eec9f55b4a91141a45b7e85226934e6

Persistent

Environment URL
staging https://pr-8330.frontend-staging.rinth.dev
production https://pr-8330.frontend.rinth.dev
storybook https://pr-8330-storybook.modrinth.workers.dev

Latest commit

Environment URL
staging https://e9e0f5f2.frontend-staging.rinth.dev
production https://cc56e2c7.frontend.rinth.dev

@IMB11 IMB11 changed the title refactor: move batch skin rendering to rust refactor: skin rendering perf changes Nov 14, 2026
@IMB11
IMB11 marked this pull request as ready for review November 14, 2026 14:47
@mergify

mergify Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Queue requested — the merge queue status continues in this comment ↓.

@mergify

mergify Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

✅ Merged into main as 318ddac at 20:21 UTC

1 min in the queue, with no time running CI.

So far

2 merge conditions met
  • github-review-approved · required by GitHub branch protection
  • any of · required by GitHub branch protection:
    • check-skipped = Lint and Test
    • check-neutral = Lint and Test
    • check-success = Lint and Test

Times in UTC · dashboard · how the merge queue works

@mergify mergify Bot added the queued label Nov 17, 2026
@mergify
mergify Bot merged commit 318ddac into main Nov 17, 2026
15 of 16 checks passed
@mergify
mergify Bot deleted the cal/skin-rendering-rust branch November 17, 2026 20:21
@mergify mergify Bot removed the queued label Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants